Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish-metrics): implement tracing for the cloudwatch reporter #2555

Merged

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented Mar 8, 2024

Description

Implementing tracing support for the Cloudwatch reporter. The reporter will use OpenTelemetry reporter in the background for tracing, and traces will be exported to AWS X-Ray.

Configuration

Cloudwatch agent (or ADOT) installation is required for local runs, but for Fargate runs the ADOT sidecar will be dynamically configured to send traces to AWS X-Ray.

  plugins:
    publish-metrics:
      - type: cloudwatch
        sendOnlyTraces: true
        traces: 
          sampleRate: 0.5
          useRequestNames: true
          annotations:
            tool: "artillery"
Screenshot 2024-02-08 at 16 25 56 Screenshot 2024-02-08 at 17 11 09

Testing

Unit tests added on publish-metrics side and an e2e test added on the cli side

Notes

  • Important: Users that wish to use this feature with Fargate runs and had already ran Artillery tests on Fargate in the past will need to delete the 'artilleryio-ecs-worker-role' IAM role and the 'artilleryio-ecs-worker-policy' IAM policy from their account prior to running tests in order for this feature to work. This is needed because the role will have to be recreated with the necessary permissions to send traces to AWS X-Ray

  • This is a new clean branch for feat(publish-metrics): implement tracing support for cloudwatch reporter #2487

Pre-merge checklist

  • Does this require an update to the docs?
  • Does this require a changelog entry?

@InesNi InesNi requested a review from a team March 25, 2024 08:48
@InesNi InesNi merged commit 61a6b69 into main Mar 28, 2024
25 checks passed
@InesNi InesNi deleted the ifazlic-art-1690-implement-tracing-for-the-cloudwatch-reporter branch March 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant