feat(cli): set nontemplated url as req name by default in metrics #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobridge
force-pushed
the
bernardobridge/art-1893-send-non-templated-url-with-metrics-by-endpoint-by-default
branch
from
e8c9132
to
bff2895
Compare
bernardobridge
force-pushed
the
bernardobridge/art-1893-send-non-templated-url-with-metrics-by-endpoint-by-default
branch
from
bff2895
to
c5c1dcc
Compare
bernardobridge
force-pushed
the
bernardobridge/art-1893-send-non-templated-url-with-metrics-by-endpoint-by-default
branch
from
c5c1dcc
to
35c427a
Compare
bernardobridge
deleted the
bernardobridge/art-1893-send-non-templated-url-with-metrics-by-endpoint-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, we will start setting a
req.nameequal to the non-templated url. This solves the issue with reports getting too big when users don't setreq.name, which is particularly relevant in Cloud Dashboard, where it becomes unreadable. It will now look like this:Users can opt-out of this behaviour by setting
groupDynamicURLs: falsein their config.Pre-merge checklist