fix: prevent incorrect "multiple metric batches" warning in tests with pause phases #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sending an empty stats object by default for every idle phase
can lead to duplicate stats objects being sent for the same
period, which leads to (incorrect) "multiple metric batches"
warnings printed to the user.
Consider the following phase definition:
phases:
- duration: 10
arrivalRate: 1
- pause: 10
Current behavior will lead to two stats objects being sent
for the period that the pause phase falls into:
- The empty stats object
- A stats object containing measurements from some of the VUs
from the first phase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running a test with a
pausephase will often print an incorrect warning:This PR fixes that behavior.
Pre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.