Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autofraction): only remove outer parentheses when they are matching #220

Merged
merged 3 commits into from
Nov 1, 2023
Merged

fix(autofraction): only remove outer parentheses when they are matching #220

merged 3 commits into from
Nov 1, 2023

Commits on Oct 30, 2023

  1. fix(autofraction): only strip parentheses when they match 

    previously, `(a)(b)/` would be erroneously transformed into `\frac{a)(b}{}`,
as algorithm would just check if first and last were open and closed parens.
now, only removes outer parentheses if they are matched.

fixes artisticat1#206
    @duanwilliam
    duanwilliam committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b38d9ad View commit details
    Browse the repository at this point in the history

  2. style: clean up code from b38d9ad 

    match coding style to that of surrounding code, reducing nesting
    @duanwilliam
    duanwilliam committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    525aaa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. fix(autofraction): add back matching outer parentheses check 

    commit 525aaa9 cleaned up code style but removed the actual fix added.
this restores said fix.
    @duanwilliam
    duanwilliam committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    80946c2 View commit details
    Browse the repository at this point in the history