Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the math tooltip appear below the line #257

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

bdm-k
Copy link
Contributor

@bdm-k bdm-k commented Feb 19, 2024

Closes #224

@artisticat1
Copy link
Owner

Thank you for the PR. Can you make this a toggleable setting?

@bdm-k
Copy link
Contributor Author

bdm-k commented Feb 19, 2024

Sure. However, since this is my first time developing an Obsidian plugin, it may take some time.

@bdm-k
Copy link
Contributor Author

bdm-k commented Feb 20, 2024

this.plugin.refreshCMExtensions();
await this.plugin.saveSettings();

saveSettings calls refreshCMExtensions internally, so line 202 is redundant. Is it all right if I correct this?

@artisticat1
Copy link
Owner

I see, thanks for catching that. Yes, feel free to correct it!

bdm-k and others added 4 commits February 21, 2024 01:35
- make mathPreviewPosition a boolean
- for block eqns in source mode, position the tooltip at end of eqn (so the tooltip doesn't block the LaTeX source)
- no need to hide position setting
@artisticat1 artisticat1 merged commit 1cae1a1 into artisticat1:main Feb 23, 2024
@artisticat1
Copy link
Owner

Thanks!

@Aradoexis
Copy link

Thank you so much! ❤

@bdm-k bdm-k deleted the tooltip-position branch March 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Math Popup Preview below the line instead of above the line
3 participants