Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] Add semantic-release and circle config #2

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

damassi
Copy link
Member

@damassi damassi commented Jun 3, 2018

Adds semantic-release for automated NPM publishing, as well as a CircleCI config.

WIP:

  • Add NPM_TOKEN to Circle (need to merge circle config first)
  • Publish package to NPM
  • Fix compilation

@damassi damassi requested a review from eessex June 3, 2018 03:46
@damassi damassi changed the title WIP -- [Lib] Add semantic-release and circle config [Lib] Add semantic-release and circle config Jun 3, 2018
tsconfig.json Outdated
"include": ["typings/*.d.ts", "src/**/*.ts", "src/**/*.tsx"],
"exclude": ["node_modules", "dist", "data", "externals", "danger"]
"include": [
"node_modules/styled-components/typings/styled-components.d.ts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't need that line anymore but we can keep it for now. I'm still working out some kinks to swap babel with tsc in this PR. artsy/reaction#715. I'll update it later today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l2succes I'll remove just to keep things clear

Copy link
Contributor

@l2succes l2succes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge once green

@damassi damassi merged commit c23d401 into artsy:master Jun 4, 2018
@damassi damassi deleted the add-semantic-release branch June 4, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants