Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo: Return compressed public keys and Ethereum addresses from get_pkeys #235

Merged
merged 1 commit into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions docs/halo-command-set.md
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,18 @@ Command:
Response:
```json
{
"publicKeys": {
"1": "042c061312771f471910ef8a3a437ac89f6ff81b2aeb0e3f5dcc2dd15d0d9d1fd7b48dba2ec753f0f70ea9b9a85df8a16e664546c9f7bad2be38e08eec63b916c7",
"2": "049faee2f29091bd63c48e8dd13e2577475c7eb4d4c6fa741300dedf5847e08f578296507382da42145d0ce5e5d6534bc94ba2ba8edbd6bb52af21223f914ceab0",
"3": "048069784d0c60e64952aa68744bb7dfff0bffa4cff0d160208a7a86600b466a433787f64b6efb0b8700e392d8ecb8ed5f1ee08f2440022d4efb8ab5ab3c2a9846"
}
"publicKeys": {
"1": "043acc264e3c10c01417a871b0f5b31eaacc4e6ee4966cd23420f48be5bc8c90f40c177c49e306d54b33071eeb2502a9bd04b4285530efbcb4dc5c05bfd2bb5d3f",
"2": "042c2215c8836febbd50a12dd1d1586c79a1b83f6f7bf36340059eba62ee7fe759aa46209a8afaaf2a96f43e47d25cee39eeff3577e704baebeff940deef5092b4"
},
"compressedPublicKeys": {
"1": "033acc264e3c10c01417a871b0f5b31eaacc4e6ee4966cd23420f48be5bc8c90f4",
"2": "022c2215c8836febbd50a12dd1d1586c79a1b83f6f7bf36340059eba62ee7fe759"
},
"etherAddresses": {
"1": "0x80aB6122F717874B4125d23440548B67eef21936",
"2": "0x78A0AFF76C8276d3108c20Cbf6249748E528b26c"
}
}
```

Expand Down
11 changes: 10 additions & 1 deletion halo/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,16 @@ async function cmdGetPkeys(options, args) {
let resp = await options.exec(payload);
let res = Buffer.from(resp.result, "hex");

return {"publicKeys": parsePublicKeys(res)};
let publicKeys = parsePublicKeys(res);
let compressedPublicKeys = {};
let etherAddresses = {};

for (let pkNo of Object.keys(publicKeys)) {
compressedPublicKeys[pkNo] = ec.keyFromPublic(publicKeys[pkNo], 'hex').getPublic().encodeCompressed('hex');
etherAddresses[pkNo] = ethers.utils.computeAddress('0x' + publicKeys[pkNo]);
}

return {publicKeys, compressedPublicKeys, etherAddresses};
}

async function cmdSign(options, args) {
Expand Down
Loading