Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo: Return etherAddress from sign command and update docs #237

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

icedevml
Copy link
Collaborator

Description

Checklist

Changes to the drivers

  • (PR Author) The affected drivers were manually tested

Changes to CLI

  • (PR Author) The change was manually tested with the CLI
  • (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
  • (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

  • (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
  • (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
  • (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

  • (PR Author) The change was manually tested in React Native app
  • (Checked by maintainer) The test suite was run through the test React Native project

@icedevml icedevml merged commit a1ebf8e into master Aug 11, 2023
6 checks passed
@icedevml icedevml deleted the feature/ether-addr branch August 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant