Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo: always pick "credential" execution method by default #414

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

icedevml
Copy link
Collaborator

@icedevml icedevml commented Oct 1, 2024

Description

Historically, the detectMethod() function was prioritizing the choice of WebNFC execution method as a default method if it was available on the current platform. This PR will change that in order to always use the "credential" execution method, since its general UX has improved a lot in the meantime.

Checklist

Changes to the drivers

  • (PR Author) The affected drivers were manually tested

Changes to CLI

  • (PR Author) The change was manually tested with the CLI
  • (PR Author) The affected CLI features are working with the standalone binary (at least one platform)
  • (Checked by maintainer) The CLI test procedure was run by the project's maintainer

Changes to web library

  • (PR Author) The change was manually tested with the web library included within a classic HTML application (flat libhalo.js)
  • (PR Author) The change was manually tested with the web library included within an app based on frontend framework (React.js or similar based on webpack)
  • (Checked by maintainer) The web test suite was run by the project's maintainer

Changes to nfc-manager driver

  • (PR Author) The change was manually tested in React Native app
  • (Checked by maintainer) The test suite was run through the test React Native project

@icedevml icedevml merged commit 048f960 into master Oct 1, 2024
6 checks passed
@icedevml icedevml deleted the feature/change-web-default branch October 1, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant