asciidoctor-kroki ruby-0.9.1 (latest available) does not work with asciidoctor 2.0.22

[dduportal]

Hi! As caught in asciidoctor/docker-asciidoctor#437, asciidoctor-kroki ruby-0.9.1 (latest available) does not work with asciidoctor 2.0.22.

• The culprit code seems to be:

  asciidoctor-kroki/ruby/lib/asciidoctor/extensions/asciidoctor_kroki/extension.rb

  Line 297 in 1a35570

  Base64.urlsafe_encode64(Zlib::Deflate.deflate(@text, 9))

• asciidoctor 2.0.22 changelog clearly states this is deprecated to support upcoming Ruby 3.4.

@mojavelinux recommens to use String#pack but I'm not good enough in Ruby to understand what it means (searching https://ruby-doc.org/3.3.0/String.html does not show me tangible result) so I'm opening an issue whether a PR.

[mojavelinux]

The equivalent code can be found here: https://github.com/ruby/base64/blob/master/lib/base64.rb#L328-L333

It would look something like this:

str = ([str].pack 'm0').tr '+/', '-_'

[mojavelinux]

The extension shouldn't be relying on Asciidoctor to load a library from stdlib (and base64 is being removed from the stdlib in Ruby 3.4 anyway).

[ggrossetie]

That's weird to remove such as useful and tiny lib from stdlib 🤔
I wonder why they thought it was a good idea.

[mojavelinux]

I totally agree that it was a very unwise choice.

[jaskij]

In the meantime, is a workaround available?

[mojavelinux]

You can also just add -r base64 when invoking the asciidoctor command.

[dduportal]

Thanks @ggrossetie , I'll watch when the new release will be available to ensure the Docker image of asciidoctor picks it!

[dduportal]

Hello @ggrossetie @mojavelinux could we release a new version of asciidoctor-kroki to ensure the fix is available (as it is blocking asciidoctor/docker-asciidoctor#437)?

As I'm requesting this, I do not mind to help if needed (and possible in term of permissions of course)

[ggrossetie]

Sorry forgot to push the release, 0.10.0 should be available soon

[ggrossetie]

@dduportal Could you please give it a try https://rubygems.org/gems/asciidoctor-kroki/versions/0.10.0 ?

[dduportal]

@dduportal Could you please give it a try https://rubygems.org/gems/asciidoctor-kroki/versions/0.10.0 ?

• The automation detected the new version and opened a PR which was successful(ly merged): Bump Asciidoctor-Kroki version to 0.10.0 docker-asciidoctor#441
• Bump Asciidoctor version to 2.0.22 docker-asciidoctor#437 is now working as expected with this new asciidoctor-kroki version.

Many thanks @ggrossetie !

[ggrossetie]

Awesome 👍🏻