Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer set to Author instead of producing software in document properties #2510

Closed
Vampire opened this issue Mar 13, 2024 · 3 comments
Closed
Assignees
Milestone

Comments

@Vampire
Copy link

Vampire commented Mar 13, 2024

If you generate a document without author line, the document properties of the generated PDF show:
image
In English the field is called "PDF Producer" which is more ambiguous in what it could mean than the german "PDF created with" literally translated.

This is imho the correct thing to have in this field,
which is also backed by the example at the end of section 14.3.3 in https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/PDF32000_2008.pdf which shows:
image

But if you set an author line on the document, that line is used as Producer:
image

In English where the field is just called "Producer" both values could fit, though it is a bit inconsistent.
But the example in the standard and the localization of Acrobat Reader suggest that the author should not be put there.

@mojavelinux
Copy link
Member

Here are the definitions of these fields according to the PDF specification:

  • /Creator (Optional) If the document was converted to PDF from another format, the name of the conforming product that created the original document from which it was converted.
  • /Producer (Optional) If the document was converted to PDF from another format, the name of the conforming product that converted it to PDF.

It would seem as though the Creator is for whatever product created the AsciiDoc (if relevant) and the Producer is for whatever product generated/produced the PDF (in this case Asciidoctor PDF + Prawn).

I would agree that Producer should be the Asciidoctor PDF credit.

Note that the Producer field can be overridden using the publisher attribute, which was requested/required by one of the users of Asciidoctor PDF long ago. (I think I'll add producer as a fallback just for completeness).

For Creator, I'm not sure. I think perhaps we should default that field to the author, but still allow it to be overridden using the creator attribute.

@mojavelinux
Copy link
Member

Here's what I'm thinking. /Producer can be overridden using the producer attribute, but will default to the Asciidoctor PDF credit line. /Creator can be overridden using the publisher attribute, but will default to the author. (Here I'm remapping the publisher attribute to /Creator instead of /Producer per the description in the PDF specification).

(We always have to populate both fields or Prawn will fill them in with the text "Prawn").

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 30, 2024
@mojavelinux
Copy link
Member

mojavelinux commented May 31, 2024

/Creator can be overridden using the publisher attribute

I sure wish there was a /Publisher field, but there just isn't (and most PDF readers don't show custom fields). So publisher → /Creator just has to mean what the author wants it to mean. What's important is that now you'll have control over both fields, which is the key focus here in my mind.

@mojavelinux mojavelinux self-assigned this May 31, 2024
@mojavelinux mojavelinux added this to the v2.3.x milestone May 31, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 31, 2024
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue May 31, 2024
…ent info to credit Asciidoctor PDF and Prawn
mojavelinux added a commit that referenced this issue Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants