Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from ast package #1204

Closed
abelsromero opened this issue May 20, 2023 · 3 comments · Fixed by #1214
Closed

Remove deprecated methods from ast package #1204

abelsromero opened this issue May 20, 2023 · 3 comments · Fixed by #1214

Comments

@abelsromero
Copy link
Member

Methods already marked should be removed for v3.0.0 release.

This includes mostly methods whose naming was aligned with Ruby and have now equivalent Java versions (same as #1202 (comment)).

We'll need to document these changes in the migration guide.

@abelsromero abelsromero added this to the 3.0.0 milestone May 20, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Jun 1, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Jun 1, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Jun 2, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Jun 2, 2023
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue Jun 2, 2023
@abelsromero
Copy link
Member Author

Finally, this is the last thing I have in mind for v3.0.0 release. @robertpanzer anything else?

@robertpanzer
Copy link
Member

Sorry for responding late.
I don't have anything on the top of my mind.
Do you think it would make sense to release sth like a 3.0.0-alpha.1?

@abelsromero
Copy link
Member Author

Do you think it would make sense to release sth like a 3.0.0-alpha.1?

I guess I have been too subtle 🙊 Let's release!

For transparency, I am really looking forward to v3.0.0 because we also have the maven-plugin v3.0.0 ready with heavy breaking changes, and I'd like to make Asciidocotorj v3 the minimum for it. It could be made optional, but is less cognitive overload, and in case of need, we also have a maven v2.5.x maintenance for older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants