Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1275. Fix unresolved dependency grolifant and okhttp-digest #1278

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

robertpanzer
Copy link
Member

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

Same as #1277, but for 2.5.x

@robertpanzer
Copy link
Member Author

Seems like we cannot build with Java 8 anymore.
Even grolifant 0.12.1 seems to be compiled at least Java 11.
Since this is just a build time dependency, and we explicitly compile for Java 8, it should still work, we just cannot test anymore.
There might be a way to use a Java 8 toolchain for running the tests, but I am not aware of how to do that.

@abelsromero
Copy link
Member

There might be a way to use a Java 8 toolchain for running the tests, but I am not aware of how to do that.

What about ending 2.5.x support and releasing 3.0.0? The first 3 alpha was June 2023.

@robertpanzer robertpanzer merged commit 9003f32 into asciidoctor:v2.5.x Aug 1, 2024
8 checks passed
@robertpanzer robertpanzer deleted the fix-build-2.5 branch August 1, 2024 10:31
@robertpanzer
Copy link
Member Author

What about ending 2.5.x support and releasing 3.0.0? The first 3 alpha was June 2023.

Yes, I agree.
We should finally go for it.
I guess there seems to be no interest in alleviating the API changes to the extension API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants