Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ERD (Haskell) with erd-go #343 #344

Merged
merged 6 commits into from
Mar 26, 2023
Merged

Replace ERD (Haskell) with erd-go #343 #344

merged 6 commits into from
Mar 26, 2023

Conversation

barthel
Copy link
Contributor

@barthel barthel commented Mar 23, 2023 •
edited by dduportal
Loading

Fixes #343

@dduportal dduportal self-requested a review March 24, 2023 08:24
dduportal
dduportal requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an excellent job!

Alas I'm blocking the PR for now because #343 (comment) .

Until we can evaluate the safety of erd-go, or contribute to it, we cannot take the risk of embedding this in our official image.

dduportal
dduportal reviewed Mar 24, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@dduportal
Copy link
Contributor

  • Added a suggestion, not blocking but important (by pinning the version of golang to the one specified in the erd-go repository)
  • Given the discussions and work on this, it is safe and useful to trigger the checks builds: that will give a feedback to everyone .

Almost there !

dduportal
dduportal reviewed Mar 24, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
dduportal
dduportal reviewed Mar 24, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
barthel and others added 3 commits March 24, 2023 17:06
@barthel @dduportal
Fix version as suggested by dduportal
d9e054c 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@barthel @dduportal
Uses 'original' golang version as suggested by dduportal
3f71fae 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
@barthel @dduportal
Uses --no-cache as dduportal suggested
3df55ef 
Co-authored-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
dduportal reviewed Mar 25, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
dduportal
dduportal requested changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I've added a suggestion tested locally (my previous suggestion about the v2 did not).

@dduportal dduportal added chore Chore tasks (CI, automation, etc.) and removed enhancement labels Mar 26, 2023
dduportal
dduportal approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ! The build time is now under the 2 min instead of 12!

👏

@dduportal dduportal merged commit e064241 into asciidoctor:main Mar 26, 2023
@dduportal dduportal mentioned this pull request May 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore Chore tasks (CI, automation, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ERD (Haskell) with erd-go
2 participants
@barthel @dduportal