Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header for GoCD 20.1 #104

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Add missing header for GoCD 20.1 #104

merged 4 commits into from
Mar 3, 2020

Conversation

nicolaasuni
Copy link
Contributor

No description provided.

Copy link
Owner

@ashwanthkumar ashwanthkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this change @nicolaasuni. I've added a minor comment on this change, if you could fix that I would be happy to merge this in.

@nicolaasuni
Copy link
Contributor Author

@ashwanthkumar I have cleaned up the code and added another fix for #105

@jefftrimm
Copy link

Just a ping to get this PR reviewed and merged as soon as is practical and cut a build. Everyone running the latest version of GoCD is running into this issue...

@ashwanthkumar
Copy link
Owner

Thanks @nicolaasuni

@ashwanthkumar ashwanthkumar merged commit d1cbdb0 into ashwanthkumar:master Mar 3, 2020
@jefftrimm
Copy link

Can you cut a release build with this fix? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants