Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #58 #64

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Fixes #58 #64

merged 1 commit into from
Dec 2, 2016

Conversation

ashwanthkumar
Copy link
Owner

Adding a new config 'truncate-changes', which is useful to display all changes or only latest 5 changes. See the issue #58 for more context.

@jdavisp3 Please have a look at this PR.

@ashwanthkumar
Fixes #58
d677be3 
Adding a new config 'truncate-changes', which is useful to display all changes or only latest 5 changes. See the issue for more context.
@ashwanthkumar ashwanthkumar mentioned this pull request Dec 2, 2016
Closed
jdavisp3
jdavisp3 approved these changes Dec 2, 2016
View reviewed changes
Copy link
Collaborator

@jdavisp3 jdavisp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look right to me.

Did you consider making the max number of changes configurable instead? (With, say, null indicating no maximum)

@ashwanthkumar
Copy link
Owner Author

@jdavisp3 I did consider but 2 reasons why I didn't go with that approach

  1. I'm not a huge fan of null. Had this been scala, I would prefer to use Option but alas Java doesn't support it :( I have an implementation in Java but that isn't great for readability.
  2. I was wondering why would someone want latest n changes over just 5? I mean it might or might not be complete anyways right? Also in my experience 5 looks pretty well for build failures assuming the pushes are small and incremental.

What do you think?

@jdavisp3
Copy link
Collaborator

jdavisp3 commented Dec 2, 2016

Yep, makes sense to me! :shipit:

@ashwanthkumar ashwanthkumar merged commit 2708d81 into master Dec 2, 2016
@ashwanthkumar ashwanthkumar deleted the truncate-changes-option branch December 2, 2016 05:33
@ashwanthkumar
Copy link
Owner Author

Thanks @jdavisp3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdavisp3 jdavisp3 jdavisp3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwanthkumar @jdavisp3