Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release missing bazel artifacts #751

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/download-artifact@v4
with:
merge-multiple: true
- run: shasum -a 256 aspect* > SHA256.txt
- run: shasum -a 256 aspect* bazel* > SHA256.txt
- name: Prepare workspace snippet
run: .github/workflows/install_snippet.sh > release_notes.txt
- name: Create GitHub draft release and upload artifacts
Expand All @@ -27,4 +27,5 @@ jobs:
body_path: release_notes.txt
files: |
aspect*
bazel*
SHA256.txt
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ After this, you should be able to merge your changes without any conflicts in th

## Releasing

1. At the commit to release from, run `./workspace_status.sh | grep STABLE_ASPECT_CLI_BAZELISK_COMPAT_VERSION`
1. Sync your local `main` branch to the commit to release from.
Run `node ./tools/workspace_status.js | grep STABLE_ASPECT_CLI_BAZELISK_COMPAT_VERSION`
to determine the current release version. This version follows our monorepo versioning scheme minus
the hash so that it is compatible with Bazelisk. See comment in `workspace_status.sh` for more info.

Expand Down
Loading