refactor: remove legacy update_pnpm_lock default value (#1624)

aspect-build · Apr 8, 2024 · 2e1da58 · 2e1da58
1 parent 13410c3
commit 2e1da58
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/docs/npm_translate_lock.md b/docs/npm_translate_lock.md
diff --git a/npm/private/npm_translate_lock.bzl b/npm/private/npm_translate_lock.bzl
@@ -163,7 +163,7 @@ def npm_translate_lock(
         pnpm_lock = None,
         npm_package_lock = None,
         yarn_lock = None,
-        update_pnpm_lock = None,
+        update_pnpm_lock = False,
         node_toolchain_prefix = "nodejs",
         yq_toolchain_prefix = "yq",
         preupdate = [],
@@ -618,11 +618,6 @@ def npm_translate_lock(
         for value_key, value_value in value.items():
             bins_string_list_dict[key].append("{}={}".format(value_key, value_value))
 
-    # Default update_pnpm_lock to True if npm_package_lock or yarn_lock is set to
-    # preserve pre-update_pnpm_lock `pnpm import` behavior.
-    if update_pnpm_lock == None and (npm_package_lock or yarn_lock):
-        update_pnpm_lock = True
-
     if not update_pnpm_lock and preupdate:
         fail("expected update_pnpm_lock to be True when preupdate are specified")