Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: 2.x regression with aliased package names #1814

Closed
alexeagle opened this issue Jun 25, 2024 · 0 comments · Fixed by #1824
Closed

[Bug]: 2.x regression with aliased package names #1814

alexeagle opened this issue Jun 25, 2024 · 0 comments · Fixed by #1824
Assignees
Labels
bug Something isn't working

Comments

@alexeagle
Copy link
Member

alexeagle commented Jun 25, 2024

What happened?

with a package.json containing something like this:

"artillery-engine-des": "npm:@des-e2e/artillery-engine-des@12.1.0",

We get an error from ts_project which looks like the linker created a file where it expected a folder?

ERROR: /services/docengine-e2e-service/BUILD.bazel:127:11: 
in deps attribute of ts_project rule //services/docengine-e2e-service:tsc: 
source file '//services/docengine-e2e-service:node_modules/artillery-engine-des' is misplaced here (expected no files). 
Since this rule was created by the macro 'ts_project', the error might have been caused by the macro implementation 

Version

rules_js 2.0 (rc5)

How to reproduce

No response

Any other information?

No response

@alexeagle alexeagle added the bug Something isn't working label Jun 25, 2024
@jbedard jbedard assigned jbedard and unassigned gregmagolan Jun 27, 2024
jbedard added a commit to jbedard/rules_js that referenced this issue Jun 27, 2024
jbedard added a commit to jbedard/rules_js that referenced this issue Jun 27, 2024
jbedard added a commit to jbedard/rules_js that referenced this issue Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants