Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shebang bug fix in launcher script #1295

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Conversation

jgao54
Copy link
Contributor

@jgao54 jgao54 commented Sep 27, 2023

Cannot have newline before shebang.

Type of change

  • Bug fix

Test plan

  • Manual testing: before this change, an image that uses this js_image_layer was still getting exec format error when trying to execute the js binary, which is expected since shebang cannot have newline in front of it. Error is fixed with this change.
  • Updated unit & e2e tests.

Cannot have newline before shebang.
@CLAassistant
Copy link

CLAassistant commented Sep 27, 2023

CLA assistant check
All committers have signed the CLA.

@jbedard
Copy link
Member

jbedard commented Sep 28, 2023

@thesayyn do you know any way to test this?

@thesayyn
Copy link
Member

can be added here

- name: 'smoke'
command: 'bash'
args: ['/app/src/main']
expectedOutput:
[
'OS',
'ARCH/CPU',
' WORKSPACE js_image_oci',
' TARGET //src:main',
' SOURCE CHECK true',
' DIRECTORY CHECK true',
' PROTO CHECK true',
' SOURCE DIRECTORY CHECK true',
]
instead of invoking it via bash, script can be invoked directly to see if it works directly.

something like

- name: 'smoke'
   entrypoint: /app/src/main

Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgao54
Copy link
Contributor Author

jgao54 commented Sep 29, 2023

I'm seeing: line 9: field entrypoint not found in type v2.CommandTest errors, going to undo the e2e test change for now.

@jgao54
Copy link
Contributor Author

jgao54 commented Sep 29, 2023

@thesayyn will need another approval, thanks!

@thesayyn
Copy link
Member

I'm seeing: line 9: field entrypoint not found in type v2.CommandTest errors, going to undo the e2e test change for now.

sorry it's supposed to be command.

@jgao54
Copy link
Contributor Author

jgao54 commented Oct 2, 2023

@thesayyn updated again.

@jgao54
Copy link
Contributor Author

jgao54 commented Oct 3, 2023

The e2e failures look unrelated to my change now.

@alexeagle alexeagle enabled auto-merge (squash) October 18, 2023 22:57
@alexeagle alexeagle merged commit 058df31 into aspect-build:main Oct 18, 2023
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants