-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shebang bug fix in launcher script #1295
Conversation
Cannot have newline before shebang.
@thesayyn do you know any way to test this? |
can be added here rules_js/e2e/js_image_oci/src/test.yaml Lines 4 to 17 in bde7389
something like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm seeing: |
@thesayyn will need another approval, thanks! |
sorry it's supposed to be |
@thesayyn updated again. |
The e2e failures look unrelated to my change now. |
format nit
Cannot have newline before shebang.
Type of change
Test plan
js_image_layer
was still gettingexec format error
when trying to execute the js binary, which is expected since shebang cannot have newline in front of it. Error is fixed with this change.