feat: import toolchains to use for copy actions #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kormide
force-pushed
the
copy-toolchains
branch
11 times, most recently
from
f6d5430
to
2a8a64c
Compare
kormide
commented
Nov 16, 2023
kormide
force-pushed
the
copy-toolchains
branch
4 times, most recently
from
eac74c3
to
57f8122
Compare
This was referenced Nov 16, 2023
kormide
force-pushed
the
copy-toolchains
branch
from
57f8122
to
4be05f9
Compare
kormide
commented
Nov 16, 2023
kormide
force-pushed
the
copy-toolchains
branch
6 times, most recently
from
4eff80a
to
1ce8cf2
Compare
kormide
force-pushed
the
copy-toolchains
branch
3 times, most recently
from
c1d9dc9
to
6575ad8
Compare
kormide
force-pushed
the
copy-toolchains
branch
from
6575ad8
to
7090261
Compare
alexeagle
approved these changes
Nov 17, 2023
ralimi
added a commit
to ralimi/rules_esbuild
that referenced
this pull request
Nov 20, 2023
upport bazel-lib 1.x and 2.x. This is analogous to aspect-build/rules_js#1355 for rules_js.
alexeagle
added a commit
to aspect-build/rules_esbuild
that referenced
this pull request
Nov 20, 2023
* feat: import toolchains to use for copy actions upport bazel-lib 1.x and 2.x. This is analogous to aspect-build/rules_js#1355 for rules_js. * chore: use bazel-lib 2.0 locally * chore: update e2e to work with newer rules_js * chore: green up --------- Co-authored-by: Alex Eagle <alex@aspect.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support bazel-lib 1.x and 2.x. Please review the first commit only.
Type of change
Test plan