Only emit aspect_rules_js_metadata when it's required #1420
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
approved these changes
Jan 2, 2024
dzbarsky
force-pushed
the
zbarsky/aspect_metadat
branch
from
815c6dc
to
b8e0961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
- Performance (a code change that improves performance)
Test plan
- Covered by existing test cases
My understanding is this file is only consumed by actions with a non-empty file, so writing an empty one is unnecessary. This saves 2.5% of files in the npm runfiles tree on typical test actions which translates to a small improvement in test runtime.
As another datapoint, in bazelbuild/bazel#8230 (comment) I computed that the average NPM package we use has around 45 files. 44/45 = 97.8% :)