Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort npm_import repository rule deps #1423

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 2, 2024

I think I had a diff similar to this when changing repository rules and figured sorting these would prevent code changes from potentially effecting order

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

@jbedard jbedard force-pushed the transitive-closure-caching branch 2 times, most recently from baeb9cf to 86056b6 Compare January 2, 2024 19:03
@jbedard jbedard marked this pull request as ready for review January 2, 2024 20:19
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard enabled auto-merge (rebase) January 2, 2024 20:24
@jbedard jbedard merged commit 6e2437a into aspect-build:main Jan 3, 2024
95 checks passed
@jbedard jbedard deleted the transitive-closure-caching branch January 3, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants