Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify pnpm parse_pnpm_name util #1424

Merged
merged 1 commit into from
Jan 16, 2024
Merged

refactor: simplify pnpm parse_pnpm_name util #1424

merged 1 commit into from
Jan 16, 2024
+32 −42

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 2, 2024 •
edited
Loading

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard marked this pull request as ready for review January 2, 2024 20:18
@jbedard jbedard enabled auto-merge (rebase) January 2, 2024 23:51
@jbedard jbedard force-pushed the store-name-refactor branch 3 times, most recently from f95e1c4 to 3ffb84b Compare January 6, 2024 07:06
gregmagolan
gregmagolan approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🌮

@jbedard jbedard force-pushed the store-name-refactor branch 3 times, most recently from dd7419d to 32a363f Compare January 15, 2024 23:49
@jbedard jbedard merged commit 0bbde82 into aspect-build:main Jan 16, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan