Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not generate repositories.bzl for bzlmod #1547

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: do not generate repositories.bzl for bzlmod #1547

merged 3 commits into from
Apr 8, 2024
+93 −28,287

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Mar 26, 2024 •
edited
Loading

Technically this shouldn't be a breaking change, the repositories.bzl should not be used within bzlmod, but maybe we should keep this in the 2.x branch?

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

@jbedard jbedard force-pushed the bzlmod-wkps-transl branch 2 times, most recently from 4115c97 to 7039223 Compare April 1, 2024 23:12
@jbedard jbedard changed the base branch from main to 2.x April 6, 2024 23:13
@jbedard jbedard force-pushed the bzlmod-wkps-transl branch 5 times, most recently from 56b8aac to 900458a Compare April 7, 2024 00:02
@jbedard jbedard marked this pull request as ready for review April 7, 2024 00:37
@jbedard
Copy link
Member Author

jbedard commented Apr 7, 2024

Depends on #1614

@jbedard jbedard mentioned this pull request Apr 7, 2024
Open
gregmagolan
gregmagolan approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbedard jbedard merged commit c51f1d7 into aspect-build:2.x Apr 8, 2024
91 checks passed
@jbedard jbedard deleted the bzlmod-wkps-transl branch April 8, 2024 01:26
jbedard added a commit that referenced this pull request Apr 9, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
050166d
gregmagolan pushed a commit that referenced this pull request Apr 9, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
8cbfe05
jbedard added a commit that referenced this pull request Apr 9, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
4cbe2ae
gregmagolan pushed a commit that referenced this pull request Apr 13, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
b2e0736
gregmagolan pushed a commit that referenced this pull request Apr 13, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
3b51865
gregmagolan pushed a commit that referenced this pull request Apr 15, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
0cb9e15
gregmagolan pushed a commit that referenced this pull request Apr 19, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
4f9c084
jbedard added a commit that referenced this pull request Apr 19, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
06a8745
gregmagolan pushed a commit that referenced this pull request Apr 20, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
beaa845
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
65113e1
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
d68203f
gregmagolan pushed a commit that referenced this pull request Apr 22, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
cba9d83
gregmagolan pushed a commit that referenced this pull request Apr 23, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
e644dc9
gregmagolan pushed a commit that referenced this pull request Apr 24, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
054171e
gregmagolan pushed a commit that referenced this pull request Apr 26, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
e371596
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
6566c42
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
32dcb33
gregmagolan pushed a commit that referenced this pull request Apr 29, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
1402458
gregmagolan pushed a commit that referenced this pull request May 6, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
03d9685
jbedard added a commit that referenced this pull request May 6, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
6a5d4db
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
0a20da7
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
ec322f1
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
86b0b65
jbedard added a commit that referenced this pull request May 8, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
8170369
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
6063d6e
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
25b1976
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan pushed a commit that referenced this pull request May 13, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
55c7786
jbedard added a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (aspect-build#1547)
f063bbe
jbedard added a commit that referenced this pull request May 14, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (#1547)
511dee2
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
fix: do not generate repositories.bzl for bzlmod (aspect-build#1547)
d34f2da
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
5a84dc7
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
fix: do not generate repositories.bzl for bzlmod (#1547)
5f6a495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @gregmagolan