Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(npm): reduce array concatenation #1859

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 20, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard force-pushed the gen-reduce-arrays branch 7 times, most recently from 41080b3 to 814382d Compare July 22, 2024 23:32
@jbedard jbedard marked this pull request as ready for review July 24, 2024 02:00
@jbedard jbedard marked this pull request as draft July 24, 2024 02:02
@jbedard jbedard force-pushed the gen-reduce-arrays branch 4 times, most recently from a1d3f28 to 7b17d6d Compare July 24, 2024 03:21
@jbedard jbedard marked this pull request as ready for review July 24, 2024 03:22
@jbedard jbedard force-pushed the gen-reduce-arrays branch 3 times, most recently from 9e1dede to 4b652db Compare July 24, 2024 19:11
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@jbedard jbedard merged commit 9ae6416 into aspect-build:main Jul 25, 2024
98 checks passed
@jbedard jbedard deleted the gen-reduce-arrays branch July 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants