Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs updates for 2.0 #1887

Merged
merged 2 commits into from
Aug 13, 2024
Merged

chore: docs updates for 2.0 #1887

merged 2 commits into from
Aug 13, 2024

Conversation

alexeagle
Copy link
Member

  • Add a migration guide, adapted from 2.0 RELEASE #1671
  • Add eslint in a few spots so it's more likely users discover it
  • Promote Aspect Workflows for CI/CD

Changes are visible to end-users: no

Test plan

Docs only

- Add a migration guide, adapted from #1671
- Add eslint in a few spots so it's more likely users discover it
- Promote Aspect Workflows for CI/CD
Copy link

aspect-workflows bot commented Aug 13, 2024

Test

All tests were cache hits

194 tests (100.0%) were fully cached saving 48s.


Test

e2e/bzlmod

All tests were cache hits

5 tests (100.0%) were fully cached saving 631ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 516ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.


Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 925ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 925ms.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 184ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 55ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 167ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 59ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 507ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

40 tests (100.0%) were fully cached saving 16s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 7s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 4s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 324ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 562ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 251ms.


Buildifier      Format

docs/migrate_2.md Outdated Show resolved Hide resolved
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for summarizing.

@alexeagle alexeagle merged commit c996609 into main Aug 13, 2024
107 checks passed
@alexeagle alexeagle deleted the up_stardoc branch August 13, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants