Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git deps cannot be stopped with CTRL-C #83

Closed
mstefani opened this issue Jan 20, 2019 · 5 comments · Fixed by #94
Closed

git deps cannot be stopped with CTRL-C #83

mstefani opened this issue Jan 20, 2019 · 5 comments · Fixed by #94
Labels
bug help wanted

Comments

@mstefani
Copy link
Contributor

This is kinda a follow up to issue #82.
I tried to stop 'git deps commit' with CTRL-C but that doesn't works. I had to kill the 'python git-deps' process.
@mstefani
Copy link
Contributor Author

mstefani commented Jan 20, 2019 •
edited by aspiers
Loading

A simple reproducer:

git clone git://source.winehq.org/git/wine.git
git deps 186d107e4d586860008e2ac5fb1e2ebdbce06145
186d107e4d586860008e2ac5fb1e2ebdbce06145 50e53643300da159a7680fb862a4f4c747a12697
263f6ef20123bd35dbcecca48a3137dc2be9ef94 282eb73bc3eafe63f3f33117370b7e891011353b
263f6ef20123bd35dbcecca48a3137dc2be9ef94 b80101eb6516e0ac778c1d61bbb26a032ccbd0a2
263f6ef20123bd35dbcecca48a3137dc2be9ef94 d5a478edfa98164665d83ba6989aca499910752f
263f6ef20123bd35dbcecca48a3137dc2be9ef94 1522282673e19f6cb31b775bafd8cb564e05d138
^C^C^C^C^Ccf22c2c16c50707b85b6700721ca146dd376b01a f3346a789ea01e578b93c7d4f0fdf870f80b446d
cf22c2c16c50707b85b6700721ca146dd376b01a a4d0abb2344f93552add6eef9a723573c76ba6a2
cf22c2c16c50707b85b6700721ca146dd376b01a b995ed00a742494dc68ed829afd51f052bada4d3
6fb0c79022323a820d122943745f9aa60a346aa0 f3346a789ea01e578b93c7d4f0fdf870f80b446d
6fb0c79022323a820d122943745f9aa60a346aa0 728bf77c83e331d821272131aaf8eb71600c2a77
6fb0c79022323a820d122943745f9aa60a346aa0 b995ed00a742494dc68ed829afd51f052bada4d3

@aspiers
Copy link
Owner

aspiers commented Jan 20, 2019

Thanks for the report. I guess it's some kind of signal handler issue maybe.

@midenok midenok mentioned this issue Apr 18, 2019
Closed
@midenok
Copy link

midenok commented Apr 18, 2019

Please fix this trivial and nasty bug ASAP!

aspiers added a commit that referenced this issue May 20, 2019
@aspiers
Revert "ignore KeyboardInterrupt"
2b04560 
This reverts commit 2a05400.  I have
no idea why I did that, but if the reason emerges after the revert, we
should address it in some other more sensible way.

Fixes #83 and #89.
@aspiers aspiers mentioned this issue May 20, 2019
Merged
@aspiers
Copy link
Owner

aspiers commented May 20, 2019

Hopefully #94 will work. Can someone else volunteer to test it?

aspiers added a commit that referenced this issue Apr 3, 2021
@aspiers
Revert "ignore KeyboardInterrupt"
bc294e3 
This reverts commit 2a05400.  I have
no idea why I did that, but if the reason emerges after the revert, we
should address it in some other more sensible way.

Fixes #83 and #89.
aspiers added a commit that referenced this issue Apr 3, 2021
@aspiers
Don't totally ignore KeyboardInterrupt
f19669e 
Commit 2a05400 ignored KeyboardInterrupt.  I'm *guessing* I did that
to avoid an ugly stacktrace, but even if so, the user's desire to
interrupt execution should not be ignored in this way.

Fixes #83 and #89.
@aspiers
Copy link
Owner

aspiers commented Apr 3, 2021

Sorry this took so long to fix :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't totally ignore KeyboardInterrupt aspiers/git-deps
3 participants
@aspiers @midenok @mstefani