Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Feishu provider #709

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Add Feishu provider #709

merged 2 commits into from
Aug 24, 2022

Conversation

vicenteyu
Copy link
Contributor

Add Feishu provider.

@vicenteyu
Add Feishu provider
150e4c0 
Signed-off-by: Vicente Yu <yxr@live.cn>
martincostello
martincostello reviewed Aug 20, 2022
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Could you add the new provider to the table in the README at the root of the repository too please?

src/AspNet.Security.OAuth.Feishu/AspNet.Security.OAuth.Feishu.csproj Show resolved Hide resolved
@martincostello
Copy link
Member

Oh, and it needs adding to the solution file too.

@martincostello
Copy link
Member

Just to confirm, have you tested that this code works correctly against the real Feishu service using a sample application?

@vicenteyu
Copy link
Contributor Author

Just to confirm, have you tested that this code works correctly against the real Feishu service using a sample application?

Yes. It works fine.

QQ截图20220821003422
QQ截图20220821003654

@martincostello martincostello added this to the 6.0.9 milestone Aug 24, 2022
@martincostello martincostello merged commit f1e2f76 into aspnet-contrib:dev Aug 24, 2022
@martincostello
Copy link
Member

Thanks again for your contribution. This package is now available from NuGet.org.

@vicenteyu vicenteyu deleted the dev-feishu branch November 1, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
new provider
Milestone
6.0.9
Development

Successfully merging this pull request may close these issues.
2 participants
@vicenteyu @martincostello