Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement KOOK provider #754

Merged
merged 5 commits into from
Apr 16, 2023
Merged

Implement KOOK provider #754

merged 5 commits into from
Apr 16, 2023

Conversation

gehongyan
Copy link
Contributor

This pull request contains the provider implementations for KOOK OAuth2.

The corresponding Issue is #753

martincostello
martincostello reviewed Jan 4, 2023
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback, but I can't access the documentation from the computer/network I'm currently on so I'll need to review it separately to cross-reference with the implementation.

docs/kook.md Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Kook/AspNet.Security.OAuth.Kook.csproj Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Kook/AspNet.Security.OAuth.Kook.csproj Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Kook/KookAuthenticationOptions.cs Outdated Show resolved Hide resolved
src/AspNet.Security.OAuth.Kook/KookAuthenticationHandler.cs Outdated Show resolved Hide resolved
@martincostello martincostello linked an issue Jan 4, 2023 that may be closed by this pull request
Implement KOOK provider #753
Closed
@gehongyan
Apply review suggestions on KOOK provider
fcafb83 
Removed IsBot, IsOnline, IsBanned claims
Updated unit tests reflecting the changes of claims
Fixed incorrect naming in project description
Optimized documentation around default scopes

Reviewed-by: martincostello
@gehongyan
Copy link
Contributor Author

The commit fcafb83 applied review suggestions from @martincostello

  • Removed IsBot, IsOnline, IsBanned claims
  • Updated unit tests reflecting the changes of claims
  • Fixed incorrect naming in project description
  • Added PackageValidationBaselineVersion to project property
  • Optimized documentation around default scopes

martincostello
martincostello reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one minor comment this looks good. I just still need to review the provider documentation against the implementation.

docs/kook.md Outdated Show resolved Hide resolved
@gehongyan @martincostello
Fix improper syntax in comments
a12ee9b 
Reviewed-by: martincostello

Co-authored-by: Martin Costello <martin@martincostello.com>
@gehongyan
Copy link
Contributor Author

gehongyan commented Feb 20, 2023 •
edited
Loading

Hi, @martincostello,
I noticed that you mentioned you are unable to access the hosted documentation site. I have updated the reference links of the source code managed on GitHub in issue #753. I will list them here as well.

The source code of the documentation can be found here:

https://github.com/kaiheila/api-docs (Simplified Chinese only)

Pages related to OAuth2 are listed here:

OAuth2 Intro: https://github.com/kaiheila/api-docs/blob/main/docs/zh-cn/oauth2.md (Simplified Chinese only)
OAuth API: https://github.com/kaiheila/api-docs/blob/main/docs/zh-cn/http/oauth.md (Simplified Chinese only)

KOOK is renamed from KaiHeiLa. The official repository is still managed in kaiheila namespace.

martincostello
martincostello reviewed Apr 16, 2023
View reviewed changes
Copy link
Member

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to review this. Just one question.

src/AspNet.Security.OAuth.Kook/KookAuthenticationOptions.cs Show resolved Hide resolved
@martincostello martincostello added this to the 7.0.2 milestone Apr 16, 2023
@martincostello martincostello merged commit 29137f7 into aspnet-contrib:dev Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello approved these changes

Assignees
No one assigned
Labels
new provider
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.

Implement KOOK provider
2 participants
@gehongyan @martincostello