Implementing PingOne provider #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/AspNet.Security.OAuth.PingOne/PingOneAuthenticationExtensions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.PingOne/PingOnePostConfigureOptions.cs
Outdated
Show resolved
Hide resolved
kevinchalet
reviewed
Jan 30, 2023
test/AspNet.Security.OAuth.Providers.Tests/PingOne/PingOneAuthenticationOptionsTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
Co-authored-by: Martin Costello <martin@martincostello.com>
drewkill32
commented
Mar 15, 2023
|
@kevinchalet @martincostello I updated the PR based on your feedback, is there anything else I need to do? Thanks |
|
Sorry, I've been busy and haven't yet had the time to sit down and review this PR (and others) and then manage a new release for them. I'll try to get to them in the next few weeks. |
|
No worries, thanks for the response. If there is any additional feedback, I'll respond to them more promptly. |
martincostello
approved these changes
Apr 16, 2023
src/AspNet.Security.OAuth.PingOne/PingOneAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
Minor documentation updates.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing PingOne as a provider
Issue #757