Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set FormatEnumsAsIntegers to true by default #454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jgreer013
Copy link

Enums should be formatted as integers by default, as deserializing string-based enums can cause exceptions when the value names (not the values themselves) are changed, or when new values are added (unlike integers, which are handled gracefully on deserialization generally).

Enums should be formatted as integers by default, as deserializing string-based enums can cause exceptions when the value names (not the values themselves) are changed, or when new values are added (unlike integers, which are handled gracefully on deserialization generally).
@jgreer013
Copy link
Author

I realize this might have ramifications for consumers of this package, but I think it makes sense to make this change, just not sure when.

@jgreer013 jgreer013 marked this pull request as ready for review March 16, 2022 20:26
@Tratcher Tratcher requested a review from JamesNK March 17, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant