Fix plus decoding (#379)

aspnet · Sep 3, 2020 · 17b8765 · 17b8765
1 parent 409add7
commit 17b8765
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/Microsoft.Owin/Infrastructure/OwinHelpers.cs b/src/Microsoft.Owin/Infrastructure/OwinHelpers.cs
@@ -562,8 +562,8 @@ internal static void ParseDelimited(string text, char[] delimiters, Action<strin
                     string value = text.Substring(equalIndex + 1, delimiterIndex - equalIndex - 1);
                     if (decodePlus)
                     {
-                        name.Replace('+', ' ');
-                        value.Replace('+', ' ');
+                        name = name.Replace('+', ' ');
+                        value = value.Replace('+', ' ');
                     }
                     if (decodeKey)
                     {

diff --git a/tests/Microsoft.Owin.Tests/QueryTests.cs b/tests/Microsoft.Owin.Tests/QueryTests.cs
@@ -12,7 +12,7 @@ public class QueryTests
         private static readonly string[] RawValues = new[] { "v1", "v2, v3", "\"v4, b\"", "v5, v6", "v7", };
         private const string JoinedValues = "v1,v2, v3,\"v4, b\",v5, v6,v7";
 
-        private const string OriginalQueryString = "q1=v1;q2=v2,b;q3=v3;q3=v4;q4;q5=v5;q5=v5";
+        private const string OriginalQueryString = "q1=v1;q2=v2,b;q3=v3;q3=v4;q4;q5=v5;q5=v5;q+6=v+6";
 
         [Fact]
         public void ParseQuery()
@@ -28,6 +28,7 @@ public void ParseQuery()
             Assert.Equal("v3,v4", query.Get("q3"));
             Assert.Null(query.Get("q4"));
             Assert.Equal("v5,v5", query.Get("Q5"));
+            Assert.Equal("v 6", query.Get("Q 6"));
         }
 
         [Fact]