Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strongly typed hub sample (Don't merge before feature is released) #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Y-Sindo
Copy link
Contributor

@Y-Sindo Y-Sindo commented Oct 21, 2021

Add strongly typed hub sample

  • NegotiationServer
    • Change another hub into strongly typed hub
  • MessagePublisher
    • Extract an interface IMessagePublisher from the MessagePublisher, and implement a StronglyTypedMessagePublisher.
    • Add an option "-s|--strongly-typed-hub" to decide which IMessagePublisher to use.
  • SignalRClient
    • Add an option "-s|--strongly-typed-hub" to decide connect to which hub.

* NegotiationServer
    * Change another hub into strongly typed hub
* MessagePublisher
    * Extract an interface `IMessagePublisher` from the `MessagePublisher`, and implement a `StronglyTypedMessagePublisher`.
    * Add an option "-s|--strongly-typed-hub" to decide which `IMessagePublisher` to use.
* SignalRClient
    * Add an option "-s|--strongly-typed-hub" to decide connect to which hub.
@Y-Sindo Y-Sindo changed the title zityang/management Add strongly typed hub sample Oct 21, 2021
@Y-Sindo Y-Sindo changed the title Add strongly typed hub sample Add strongly typed hub sample (Don't merge before feature is released) Oct 21, 2021
@@ -25,13 +26,23 @@ static void Main(string[] args)
app.HelpOption("--help");

var userIdOption = app.Option("-u|--userIdList", "Set user ID list", CommandOptionType.MultipleValue, true);
var stronglyTypedOption = app.Option("-s|--strongly-typed", "Use strongly typed hub.", CommandOptionType.NoValue);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stronglyTypedOption

maybe add another program for strongly typed hub instead? frankly speaking, I don't see how appealing the strongly typed one is from the sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants