Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Renaming LogLevel.Verbose to Trace #299 #314

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Conversation

JunTaoLuo
Copy link
Contributor

Issue #299
Renaming LogLevels in logging so that Verbose is renamed to Trace and is considered less severe than Debug.

Most severe level listed first:

Current Levels New Levels
Critical Critical
Error Error
Warning Warning
Information Information
Verbose Debug
Debug Trace

I will update the affected repos:

To keep the current order of severity existing Verbose messages will be changed to Debug and existing Debug messages will be changed to Trace.

@dnfclas
Copy link

dnfclas commented Dec 7, 2015

Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@JunTaoLuo
Copy link
Contributor Author

cc @kichalla

@kichalla
Copy link
Member

kichalla commented Dec 7, 2015

To keep the current order of severity existing Verbose messages will be changed to Debug and existing Debug messages will be changed to Trace.

I am a bit confused...the title says Verbose is becoming Trace, but the above statement is different...which is correct?

@JunTaoLuo
Copy link
Contributor Author

@kichalla the original intent of #299 was to swap the order of verbose and debug. But it was later decided to rename verbose to trace. To illustrate how the current severity level are maintained, take a look at DataProtection

@kichalla
Copy link
Member

kichalla commented Dec 7, 2015

:shipit:

@JunTaoLuo
Copy link
Contributor Author

All PRs are out. I'll start merging and keeping an eye on the CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants