Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Set background color with foreground color in ConsoleLogger #386

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

BrennanConroy
Copy link
Member

@Eilon
Copy link
Member

Eilon commented Mar 14, 2016

:shipit:

@davidfowl
Copy link
Member

Screenshot on osx? 😄

@Eilon
Copy link
Member

Eilon commented Mar 14, 2016

@davidfowl it looks like a clown ate a unicorn 😄

@davidfowl
Copy link
Member

Is it going to put a black background on my white console with white text?

@BrennanConroy
Copy link
Member Author

It's going to use your default colors for everything except the log level text, logger name, and eventid

Sent from my HTC

----- Reply message -----
From: "David Fowler" notifications@github.com
To: "aspnet/Logging" Logging@noreply.github.com
Cc: "Brennan Conroy" brecon@microsoft.com
Subject: [Logging] Set background color with foreground color in ConsoleLogger (#386)
Date: Sun, Mar 13, 2016 8:38 PM

Is it going to put a black background on my white console with white text?

Reply to this email directly or view it on GitHubhttps://github.com//pull/386#issuecomment-196122711.

@Eilon
Copy link
Member

Eilon commented Mar 14, 2016

Yeah the colorization is only for the "header" of each log entry, for which we explicitly set both background and foreground color (to ensure good contrast). Then the log details are in whatever color you had in your console.

@BrennanConroy BrennanConroy merged commit bc8ba8a into dev Mar 14, 2016
@BrennanConroy BrennanConroy deleted the brecon/console_color branch March 14, 2016 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants