Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Change the data type of VirtualPathData.VirtualPath #270

Closed
pranavkm opened this issue Dec 31, 2015 · 1 comment
Closed

Change the data type of VirtualPathData.VirtualPath #270

pranavkm opened this issue Dec 31, 2015 · 1 comment
Assignees
@pranavkm
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@pranavkm
Copy link
Contributor

Based on discussions in #269 (comment):
we store Url encoded path and query components in this field. However the type is designed to not contain non encoded path component.

Alternatives to represent it:

  • Vanilla string
  • Two separate components PathString + QueryString
  • Uri (think it might get treated as a relative path)
@pranavkm
Copy link
Contributor Author

cc @Tratcher

@Eilon Eilon added this to the 1.0.0-rc2 milestone Dec 31, 2015
pranavkm added a commit that referenced this issue Jan 4, 2016
@pranavkm
Change the data type of VirtualPathData.VirtualPath
156016e 
Fixes #270
pranavkm added a commit that referenced this issue Jan 4, 2016
@pranavkm
Change the data type of VirtualPathData.VirtualPath
9ed5032 
Fixes #270
pranavkm added a commit that referenced this issue Jan 4, 2016
@pranavkm
Change the data type of VirtualPathData.VirtualPath
51bfea3 
Fixes #270
@pranavkm pranavkm mentioned this issue Jan 4, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
2 participants
@pranavkm @Eilon