Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
@BrennanConroy
BrennanConroy committed Mar 16, 2018
1 parent 69489f3 commit caa12b8
Showing 1 changed file with 9 additions and 33 deletions.
42 changes: 9 additions & 33 deletions test/Microsoft.AspNetCore.Sockets.Tests/ConnectionManagerTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ public void NewConnectionsCanBeRetrieved()
public void AddNewConnection()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);

var transport = connection.Transport;

Expand All @@ -62,10 +59,7 @@ public void AddNewConnection()
public void RemoveConnection()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);

var transport = connection.Transport;

Expand All @@ -84,10 +78,7 @@ public void RemoveConnection()
public async Task CloseConnectionsEndsAllPendingConnections()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);

connection.ApplicationTask = Task.Run(async () =>
{
Expand All @@ -99,7 +90,7 @@ public async Task CloseConnectionsEndsAllPendingConnections()
}
finally
{
connection.Transport.Input.AdvanceTo(result.Buffer.End);
connection.Transport.Input.AdvanceTo(result.Buffer.End);
}
});

Expand All @@ -125,10 +116,7 @@ public async Task CloseConnectionsEndsAllPendingConnections()
public async Task DisposingConnectionMultipleTimesWaitsOnConnectionClose()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);
var tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

connection.ApplicationTask = tcs.Task;
Expand All @@ -148,10 +136,7 @@ public async Task DisposingConnectionMultipleTimesWaitsOnConnectionClose()
public async Task DisposingConnectionMultipleGetsExceptionFromTransportOrApp()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);
var tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

connection.ApplicationTask = tcs.Task;
Expand All @@ -175,10 +160,7 @@ public async Task DisposingConnectionMultipleGetsExceptionFromTransportOrApp()
public async Task DisposingConnectionMultipleGetsCancellation()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);
var tcs = new TaskCompletionSource<object>(TaskCreationOptions.RunContinuationsAsynchronously);

connection.ApplicationTask = tcs.Task;
Expand All @@ -199,10 +181,7 @@ public async Task DisposingConnectionMultipleGetsCancellation()
public async Task DisposeInactiveConnection()
{
var connectionManager = CreateConnectionManager();
var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);

Assert.NotNull(connection.ConnectionId);

Expand Down Expand Up @@ -230,10 +209,7 @@ public async Task ApplicationLifetimeIsHookedUp()

appLifetime.Start();

var connection = connectionManager.CreateConnection();
var pair = DuplexPipe.CreateConnectionPair(PipeOptions.Default, PipeOptions.Default);
connection.Application = pair.Transport;
connection.Transport = pair.Application;
var connection = connectionManager.CreateConnection(PipeOptions.Default, PipeOptions.Default);

connection.Application.Output.OnReaderCompleted((error, state) =>
{
Expand Down

0 comments on commit caa12b8

Please sign in to comment.