-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Serverless 1.0 #26
base: master
Are you sure you want to change the base?
Conversation
How do you propose we continue to support users of 0.5.x? Release to npm with a beta version like the core library is doing? I've been heads down lately working on a project that is running 0.5.6 so I haven't been able to check out all the new goodies in 1.0beta. |
I think we can do both. I haven't changed the 0.5 plugin, so this still works with plugins: [
"serverless-webpack-plugin"
] Instead, I placed the new plugin in a 1.0 directory, so this works with plugins:
- serverless-webpack-plugin/1.0 Plugins are easier to write for I think it would be a good idea to release with a beta version like the core library is doing. In fact it may be cool to align the version numbers with core as best we can. Maybe. I've also been up to my eyeballs so haven't written tests yet. Hoping to do that this weekend. |
IMHO maintaining two versions in the same repository feels a bit tedious (think about two sets of node module dependencies). I'd suggest moving 0.5 compatible stuff to 0.5 branch, and maintaining it there. When new versions are released, they could be 0.5.x. It would be almost semver compatible, considering these changes were just patches and new feature development would happen in master. The master branch could be then kept in sync with serverless master branch, and if a 1.0 compatible version comes out and works against sls 1.0 (when it's out), then such version could be released in npm repo as well. I think such a way would be intuitive for the developers using the package, yet it would force to follow the sls development. |
Hello! I'd like to use this plugin with serverless 1.0. What would be required for this to be merged in? |
Adds a new plugin to support
webpack
bundling forServerless 1.0
.npm run build
to compilees6
toes5
es6
linting support