term.svg files require two SNAPSHOTS=overwrite runs to be rendered properly
#257
Comments
|
Should be fixed in snapbox-v0.5.3 |
bors
added a commit
to rust-lang/cargo
that referenced
this issue
Feb 23, 2024
test(cli): Verify terminal styling ### What does this PR try to resolve? This uses a new feature from snapbox that let's us render terminal styling in SVG files. This let's us see / visualize ANSI escape codes, including in github's UI (will render images, including side-by-side images for diffs). ### How should we test and review this PR? Potential concerns - assert-rs/snapbox#257: If the snapshot file doesn't exist, you need to `SNAPSHOTS=overwrite` twice - #9012: because we narrow the enabling of colors to cargo via `CARGO_TERM_COLOR`, clap doesn't know about it and those are rendered without color - File size: `du -ch tests` reported 13MB before and after - Loss of information: this doesn't yet include links but we already weren't snapshotting these - Unconditionally turning on styling and snapshotting for it for all "ui" tests - Too many SVGs in one PR can negatively affect github's UI ### Additional information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The first run loads the expected value, which is an error, and loses track of the intended data format. We then write out the actual value blindly. The second run loads the value as an SVG (which isn't an SVG but we don't validate) and so we coerce the actual to an SVG and write it out
The text was updated successfully, but these errors were encountered: