Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Applicability in LSP #4186

Closed
Tracked by #4181
MichaReiser opened this issue May 2, 2023 · 4 comments
Closed
Tracked by #4181

Respect Applicability in LSP #4186

MichaReiser opened this issue May 2, 2023 · 4 comments
Assignees

Comments

@MichaReiser
Copy link
Member

MichaReiser commented May 2, 2023

This task is part of #4181 and it depends on #4183 and #4185

  • Double check if we need to change the LSP fix command to use --fix-unsafe when applying a code fix.
  • Change the fixAll action handler to only apply safe fixes by default
  • Introduce a new option to also run unsafe fixes as part of fixAll
@zanieb
Copy link
Member

zanieb commented Oct 7, 2023

Discussed more at #6962 (comment)

@zanieb zanieb self-assigned this Oct 7, 2023
@dhruvmanila
Copy link
Member

Additionally, would having unsafe-fixes = true in the config mean that the fixAll code action includes them?

@zanieb
Copy link
Member

zanieb commented Oct 12, 2023

Yes, I think it should.

@charliermarsh
Copy link
Member

I think applicability is now respected in the LSP but @zanieb correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants