Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyupgrade.keep-runtime-typing should be ignored for .pyi stub files #5640

Closed
monosans opened this issue Jul 10, 2023 · 1 comment · Fixed by #5653
Closed

pyupgrade.keep-runtime-typing should be ignored for .pyi stub files #5640

monosans opened this issue Jul 10, 2023 · 1 comment · Fixed by #5653
Assignees
@charliermarsh
Labels
accepted Ready for implementation rule Implementing or modifying a lint rule

Comments

@monosans
Copy link
Contributor

Should the pyupgrade.keep-runtime-typing setting really apply to .pyi stub files? I think not, because they don't have runtime, so they should always use the new type annotation syntax.
@charliermarsh
Copy link
Member

I think you're right -- we can probably ignore keep-runtime-typing in those files.

@charliermarsh charliermarsh added rule Implementing or modifying a lint rule accepted Ready for implementation labels Jul 10, 2023
@charliermarsh charliermarsh self-assigned this Jul 10, 2023
@charliermarsh charliermarsh mentioned this issue Jul 10, 2023
Merged
charliermarsh added a commit that referenced this issue Jul 10, 2023
@charliermarsh
Always allow PEP 585 and PEP 604 rewrites in stub files (#5653)
ed87214 
Closes #5640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
accepted Ready for implementation rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always allow PEP 585 and PEP 604 rewrites in stub files astral-sh/ruff
2 participants
@charliermarsh @monosans