Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to license in README #11124

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix link to license in README #11124

merged 1 commit into from
Apr 24, 2024

Conversation

KPCOFGS
Copy link
Contributor

@KPCOFGS KPCOFGS commented Apr 24, 2024

Summary

Updated the readme file, so the license shields.io tag appeared in the README file would actually take users to the LICENSE file

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Apr 24, 2024
@MichaReiser MichaReiser changed the title Update README.md Fix link to license in README Apr 24, 2024
@MichaReiser MichaReiser merged commit c9c2e7b into astral-sh:main Apr 24, 2024
17 checks passed
@charliermarsh
Copy link
Member

Wait, I think this won't work properly when we publish to PyPI.

@MichaReiser
Copy link
Member

Hmm, I always forget about PyPI's markdown support. We can revert? Although I think the new version is better than the old one where it just linked back to PyPI?

@charliermarsh
Copy link
Member

We do have a transform_readme.py step where we could implement "rewrite for PyPI".

@KPCOFGS
Copy link
Contributor Author

KPCOFGS commented Apr 26, 2024

Hello, I see what you all are talking about now. Please check out PR #11155 as an attempt to solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants