-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[red-knot] Extract red_knot_python_semantic
crate
#11926
Conversation
377196e
to
05ec870
Compare
Oh, I missed some doctests. I'll fix the test failures before merging. |
05ec870
to
9fbb4f7
Compare
@@ -177,15 +179,6 @@ impl std::fmt::Display for ModuleName { | |||
} | |||
} | |||
|
|||
#[derive(Copy, Clone, Debug, Eq, PartialEq, Hash)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this declaration and instead use the one from red_knot_python_semantic
to silence cargo shear
that the red_knot_python_semantic
crate is unused (which is true, but not for long)
9abe86f
to
4c189af
Compare
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
E999 | 1 | 1 | 0 | 0 | 0 |
Formatter (stable)
✅ ecosystem check detected no format changes.
Formatter (preview)
✅ ecosystem check detected no format changes.
Summary
Extract the red knot code from
ruff_python_semantic
and move it into its own crate because we don't expect to share any logic between the two semantic models.Test Plan
cargo build