[red-knot] Add tracing to Salsa queries #11949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
changed the base branch from
main
to
salsa-9-red_knot_python_semantic
MichaReiser
force-pushed
the
salsa-tracing
branch
from
d063d6e
to
03e34b1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds tracing instrumentation to Salsa queries.
I intentionally didn't use the
#[tracing::instrument]attribute because, depending on the ordering, the attribute is applied to the query implementation only or the query implementation and thegetfunction that retrieves the cached value or calls the query implementation.Using
debug_span!avoids the ambiguity and has the added benefit that we can call theDebugWithDbimplementation instead of justdebugon the arguments.