Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyupgrade: converts universal_newlines to text in subprocess.run #1403

Merged
merged 9 commits into from
Dec 27, 2022
Merged

Pyupgrade: converts universal_newlines to text in subprocess.run #1403

merged 9 commits into from
Dec 27, 2022
+142 −5

Conversation

colin99d
Copy link
Contributor

@colin99d colin99d commented Dec 27, 2022 •
edited
Loading

A part of #827.

@colin99d
Copy link
Contributor Author

This file is outdated. You may have to rerun 'cargo dev generate-options' and/or 'cargo dev generate-rules-table'.
@charliermarsh if we have all these commands that just need to be run every time, why not add it do the CI so that contributors don't need to worry about it?

@charliermarsh
Copy link
Member

@colin99d - I'm hoping to make it a build step so that it all gets built automatically.

@charliermarsh
Copy link
Member

Eh, maybe some of these are inappropriate for a cargo build script.

@charliermarsh charliermarsh merged commit c590351 into astral-sh:main Dec 27, 2022
@colin99d colin99d deleted the un_nl_to_txt branch December 27, 2022 23:30
renovate bot added a commit to ixm-one/pytest-cmake-presets that referenced this pull request Dec 28, 2022
@renovate
⬆️ Update dependency ruff to ^0.0.196 (#7)
84781d8 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ruff](https://github.com/charliermarsh/ruff) | `^0.0.195` ->
`^0.0.196` |
[![age](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/compatibility-slim/0.0.195)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/pypi/ruff/0.0.196/confidence-slim/0.0.195)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>charliermarsh/ruff</summary>

###
[`v0.0.196`](https://github.com/charliermarsh/ruff/releases/tag/v0.0.196)

[Compare
Source](https://github.com/charliermarsh/ruff/compare/v0.0.195...v0.0.196)

#### What's Changed

- Implement pyupgrade check for io.open alias by
[@&#8203;squiddy](https://github.com/squiddy) in
[astral-sh/ruff#1399
- Tweak secret detection for playground releases by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[astral-sh/ruff#1402
- Support isort's force-single-line option by
[@&#8203;squiddy](https://github.com/squiddy) in
[astral-sh/ruff#1366
- Replace `make_tokenize` with `make_tokenizer_located` by
[@&#8203;harupy](https://github.com/harupy) in
[astral-sh/ruff#1405
- Add cargo +nightly dev generate-all by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[astral-sh/ruff#1404
- Allow specification of explicit docstring convention by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[astral-sh/ruff#1408
- Pyupgrade: converts `universal_newlines` to `text` in `subprocess.run`
by [@&#8203;colin99d](https://github.com/colin99d) in
[astral-sh/ruff#1403
- Fix invalid reference to ruff_options.rs by
[@&#8203;charliermarsh](https://github.com/charliermarsh) in
[astral-sh/ruff#1409

**Full Changelog**:
astral-sh/ruff@v0.0.195...v0.0.196

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/ixm-one/pytest-cmake-presets).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43My4zIiwidXBkYXRlZEluVmVyIjoiMzQuNzMuMyJ9-->

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squiddy squiddy squiddy left review comments

@charliermarsh charliermarsh charliermarsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin99d @charliermarsh @squiddy