Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RustPyhon and enable full-lexer feature #4442

Merged
merged 1 commit into from
May 16, 2023

Conversation

youknowone
Copy link
Contributor

@youknowone youknowone commented May 15, 2023

Using features on workspace is regarded as a sort of anti-pattern.
But if the all workspace crates are only used to build binary, it will be fine.
Which way do you prefer?

I'd like to suggest use rustpython-parser dependency only from ruff_rustpython and other crates to use only that crates

@MichaReiser MichaReiser merged commit 6049aab into astral-sh:main May 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.01     14.1±0.15ms     2.9 MB/sec    1.00     13.9±0.10ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.4±0.01ms     4.9 MB/sec    1.00      3.4±0.01ms     4.9 MB/sec
linter/all-rules/numpy/globals.py          1.00    423.3±0.84µs     7.0 MB/sec    1.01    426.7±0.61µs     6.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.8±0.02ms     4.4 MB/sec    1.01      5.9±0.04ms     4.4 MB/sec
linter/default-rules/large/dataset.py      1.00      6.7±0.02ms     6.0 MB/sec    1.01      6.8±0.02ms     6.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1458.3±10.61µs    11.4 MB/sec    1.01   1466.0±2.71µs    11.4 MB/sec
linter/default-rules/numpy/globals.py      1.00    163.1±0.30µs    18.1 MB/sec    1.00    163.4±3.70µs    18.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.4 MB/sec    1.01      3.1±0.01ms     8.3 MB/sec
parser/large/dataset.py                    1.00      5.4±0.00ms     7.6 MB/sec    1.01      5.4±0.00ms     7.5 MB/sec
parser/numpy/ctypeslib.py                  1.00   1045.7±1.31µs    15.9 MB/sec    1.02   1070.0±0.58µs    15.6 MB/sec
parser/numpy/globals.py                    1.00    108.2±0.23µs    27.3 MB/sec    1.02    110.1±0.86µs    26.8 MB/sec
parser/pydantic/types.py                   1.00      2.3±0.00ms    11.2 MB/sec    1.01      2.3±0.00ms    11.1 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     21.1±0.85ms  1971.7 KB/sec    1.01     21.4±0.92ms  1942.8 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.4±0.27ms     3.1 MB/sec    1.00      5.4±0.26ms     3.1 MB/sec
linter/all-rules/numpy/globals.py          1.02   643.8±36.26µs     4.6 MB/sec    1.00   628.6±31.70µs     4.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.8±0.35ms     2.9 MB/sec    1.00      8.8±0.32ms     2.9 MB/sec
linter/default-rules/large/dataset.py      1.01     10.6±0.37ms     3.9 MB/sec    1.00     10.5±0.39ms     3.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.2±0.11ms     7.6 MB/sec    1.00      2.2±0.10ms     7.6 MB/sec
linter/default-rules/numpy/globals.py      1.00   264.7±19.69µs    11.1 MB/sec    1.05   276.6±19.74µs    10.7 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.7±0.37ms     5.4 MB/sec    1.01      4.8±0.27ms     5.3 MB/sec
parser/large/dataset.py                    1.04      8.9±0.32ms     4.6 MB/sec    1.00      8.6±0.33ms     4.7 MB/sec
parser/numpy/ctypeslib.py                  1.02  1740.7±80.14µs     9.6 MB/sec    1.00  1712.1±107.76µs     9.7 MB/sec
parser/numpy/globals.py                    1.02    175.3±9.32µs    16.8 MB/sec    1.00    172.2±9.81µs    17.1 MB/sec
parser/pydantic/types.py                   1.02      3.9±0.17ms     6.6 MB/sec    1.00      3.8±0.15ms     6.8 MB/sec

@youknowone youknowone deleted the full-lexer branch May 16, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants