Use "manual" fixability for E731 in shadowed context #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Jun 29, 2023
| #: E731 | ||
| class F: | ||
| def scope(): | ||
| # E731 | ||
| f = lambda x: 2 * x |
There was a problem hiding this comment.
Every case here is now in its own scope, to avoid interference with the shadowing rules we're enforcing.
charliermarsh
added
bug
zanieb
reviewed
Jun 29, 2023
Co-authored-by: Zanie <contact@zanie.dev>
zanieb
approved these changes
Jun 29, 2023
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Jul 3, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `^0.0.275` -> `^0.0.276` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.276`](https://github.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.275...v0.0.276) <!-- Release notes generated using configuration in .github/release.yml at v0.0.276 --> See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://github.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@​density](https://github.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#​5402](https://github.com/astral-sh/ruff/issues/5402)) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@​intgr](https://github.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@​harupy](https://github.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@​mayrholu](https://github.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@​hauntsaninja](https://github.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@​mayrholu](https://github.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@​hauntsaninja](https://github.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@​ethunk](https://github.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@​LouisDISPA](https://github.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jankatins
added a commit
to jankatins/pr-workflow-example
that referenced
this pull request
Jul 3, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `0.0.275` -> `0.0.276` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.276`](https://github.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.275...v0.0.276) <!-- Release notes generated using configuration in .github/release.yml at v0.0.276 --> See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://github.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@​density](https://github.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#​5402](https://github.com/astral-sh/ruff/issues/5402)) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@​intgr](https://github.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@​harupy](https://github.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@​mayrholu](https://github.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@​hauntsaninja](https://github.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@​mayrholu](https://github.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@​hauntsaninja](https://github.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@​ethunk](https://github.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@​LouisDISPA](https://github.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jankatins/pr-workflow-example). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
renovate bot
added a commit
to allenporter/pyrainbird
that referenced
this pull request
Jul 5, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `==0.0.275` -> `==0.0.277` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.277`](https://github.com/astral-sh/ruff/compare/v0.0.276...v0.0.277) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.276...v0.0.277) ### [`v0.0.276`](https://github.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.275...v0.0.276) <!-- Release notes generated using configuration in .github/release.yml at v0.0.276 --> See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://github.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@​density](https://github.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#​5402](https://github.com/astral-sh/ruff/issues/5402)) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@​intgr](https://github.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@​harupy](https://github.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@​mayrholu](https://github.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@​hauntsaninja](https://github.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@​mayrholu](https://github.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@​hauntsaninja](https://github.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@​ethunk](https://github.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@​LouisDISPA](https://github.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMiIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to allenporter/flux-local
that referenced
this pull request
Jul 15, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://beta.ruff.rs/docs) ([source](https://github.com/astral-sh/ruff), [changelog](https://github.com/astral-sh/ruff/releases)) | `==0.0.275` -> `==0.0.278` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.0.278`](https://github.com/astral-sh/ruff/releases/tag/v0.0.278) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.277...v0.0.278) <!-- Release notes generated using configuration in .github/release.yml at main --> See the [release blog post](https://astral.sh/blog/ruff-v0.0.278) for more, including detailed descriptions of any newly added rules. #### What's Changed ##### Rules - \[`pylint`] Implement `typevar-bivariance` (`PLC0131`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5517 - \[`flake8-pyi`] Implement `unnecessary-literal-union` (`PYI030`) by [@​zanieb](https://github.com/zanieb) in [astral-sh/ruff#5570 - \[`pylint`] Implement `type-name-incorrect-variance` (`PLC0105`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5651 - \[`ruff`] Implement `unnecessary-list-allocation-for-first-element` (`RUF015`) by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5549 - \[`flake8-bugbear`] Implement `re-sub-positional-args` (`B034`) by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5669 - \[`ruff`] Implement `invalid-index-type` (`RUF016`) by [@​zanieb](https://github.com/zanieb) in [astral-sh/ruff#5602 ##### Settings - \[`isort`] Add `--case-sensitive` flag by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5539 - \[`isort`] Support globbing in `isort` options by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5473 ##### Bug Fixes - Support autofix for some multiline `str.format` calls by [@​harupy](https://github.com/harupy) in [astral-sh/ruff#5638 - Avoid triggering `unnecessary-map` (`C417`) for late-bound lambdas by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5520 - Avoid triggering DTZ001-006 when using `.astimezone()` by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5524 - Enable attribute lookups via semantic model by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5536 - Avoid syntax errors when rewriting str(dict) in f-strings by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5538 - Differentiate between runtime and typing-time annotations by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5575 - Only run pyproject.toml lint rules when enabled by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5578 - Refactor isort directive skips to use iterators by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5623 - Allow descriptor instantiations in dataclass fields by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5537 - Refactor `noqa` directive parsing away from regex-based implementation by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5554 - Emit warnings for invalid `# noqa` directives by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5571 - Support individual codes on `# flake8: noqa` directives by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5618 - Add `tkinter` import convention by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5626 - Avoid `PERF401` if conditional depends on list var by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5603 - Fix typo in complex-if-statement-in-stub message by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5635 - Make TRY301 trigger only if a `raise` throws a caught exception by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5455 - Skip flake8-future-annotations checks in stub files by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5652 - Always allow PEP 585 and PEP 604 rewrites in stub files by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5653 - Add support for `Union` declarations without `|` to PYI016 by [@​zanieb](https://github.com/zanieb) in [astral-sh/ruff#5598 - Ignore `_name_` and `_value_` accesses in `flake8-self` rules by [@​monosans](https://github.com/monosans) in [astral-sh/ruff#5663 - Refactor `repeated_keys()` to use `ComparableExpr` by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5696 #### New Contributors - [@​karosis88](https://github.com/karosis88) made their first contribution in [astral-sh/ruff#5560 - [@​petermattia](https://github.com/petermattia) made their first contribution in [astral-sh/ruff#5579 - [@​DimitriPapadopoulos](https://github.com/DimitriPapadopoulos) made their first contribution in [astral-sh/ruff#5607 **Full Changelog**: astral-sh/ruff@v0.0.277...v0.0.278 ### [`v0.0.277`](https://github.com/astral-sh/ruff/releases/tag/v0.0.277) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.276...v0.0.277) <!-- Release notes generated using configuration in .github/release.yml at v0.0.277 --> #### What's Changed ##### Breaking Changes - Add .ipynb_checkpoints, .pyenv, .pytest_cache, and .vscode to default excludes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5513 ##### Rules - \[`pylint`] Implement Pylint `typevar-name-mismatch` (`C0132`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5501 ##### Settings - Add `ruff rule --all` subcommand (with JSON output) by [@​akx](https://github.com/akx) in [astral-sh/ruff#5059 ##### Bug Fixes - Fix eval detection for suspicious-eval-usage by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5506 - Avoid PERF rules for iteration-dependent assignments by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5508 - Avoid returning first-match for rule prefixes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5511 **Full Changelog**: astral-sh/ruff@v0.0.276...v0.0.277 ### [`v0.0.276`](https://github.com/astral-sh/ruff/releases/tag/v0.0.276) [Compare Source](https://github.com/astral-sh/ruff/compare/v0.0.275...v0.0.276) <!-- Release notes generated using configuration in .github/release.yml at v0.0.276 --> See the [release blog post](https://astral.sh/blog/ruff-v0.0.276) for more, including detailed descriptions of any newly added rules. #### What's Changed Highlights include: experimental support for linting Jupyter Notebooks. To opt-in to linting Jupyter Notebook files, add the `*.ipynb` pattern to your [`include`](settings.md#include) setting, like so: ```toml [tool.ruff] ### Allow Ruff to discover `*.ipynb` files. include = ["*.py", "*.pyi", "**/pyproject.toml", "*.ipynb"] ``` This will prompt Ruff to discover Jupyter Notebook files in any specified directories, and lint them accordingly. Jupyter Notebook support is currently opt-in and experimental. We'd love your help testing it out. Have feedback? Run into issues? [Let us know!](https://github.com/astral-sh/ruff/issues/new) ##### New Rules - \[`flake8-pyi`] Implement `PYI002`, `PYI003`, `PYI004`, `PYI005` by [@​density](https://github.com/density) in [astral-sh/ruff#5457 - \[`numpy`] Implement `numpy-deprecated-function` (`NPY003`) by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5468 - \[`perflint`] Implement `unnecessary-list-cast` (`PERF101`) by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5121 - \[`perflint`] Implement `try-except-in-loop` (`PERF203`) by [@​evanrittenhouse](https://github.com/evanrittenhouse) in [astral-sh/ruff#5166 - \[`perflint`] Implement `manual-list-comprehension` (`PERF401`) and `manual-list-copy` (`PERF402`) rules by [@​qdegraaf](https://github.com/qdegraaf) in [astral-sh/ruff#5298 - \[`pylint`] Implement Pylint `single-string-used-for-slots` (`C0205`) as `single-string-slots` (`PLC0205`) by [@​tjkuson](https://github.com/tjkuson) in [astral-sh/ruff#5399 ##### Jupyter - Experimental release for Jupyter notebook integration by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5363 - Enable --watch for Jupyter notebooks by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5394 - Consider Jupyter index for code frames (`--show-source`) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5402 - fixup! Consider Jupyter index for code frames (`--show-source`) ([#​5402](https://github.com/astral-sh/ruff/issues/5402)) by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5414 ##### Settings - \[`pyupgrade`] Restore the `keep-runtime-typing` setting by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5470 - Add `PythonVersion::Py312` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5316 ##### Bug Fixes - Support `pydantic.BaseSettings` in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5312 - Allow `__slots__` assignments in `mutable-class-default` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5314 - Avoid syntax errors when removing f-string prefixes by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5319 - Ignore unpacking in `iteration-over-set` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5392 - Replace same length equal line with dash line in D407 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5383 - Exclude docstrings from PYI053 by [@​intgr](https://github.com/intgr) in [astral-sh/ruff#5405 - Use "manual" fixability for E731 in shadowed context by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5430 - Detect consecutive, non-newline-delimited NumPy sections by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5467 - Fix `unnecessary-encode-utf8` to fix `encode` on parenthesized strings correctly by [@​harupy](https://github.com/harupy) in [astral-sh/ruff#5478 - Allow `Final` assignments in stubs by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5490 - Respect `abc` decorators when classifying function types by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5315 - Allow `@Author` format for "Missing Author" rule in `flake8-todos` by [@​mayrholu](https://github.com/mayrholu) in [astral-sh/ruff#4903 - Ignore type aliases for RUF013 by [@​dhruvmanila](https://github.com/dhruvmanila) in [astral-sh/ruff#5344 - Change W605 autofix to use raw strings if possible by [@​hauntsaninja](https://github.com/hauntsaninja) in [astral-sh/ruff#5352 - Add space when migrating to raw string by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5358 - Update the `invalid-escape-sequence` rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5359 - Include BaseException in B017 rule by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5466 - \[`flake8-django`] Skip duplicate violations in `DJ012` by [@​charliermarsh](https://github.com/charliermarsh) in [astral-sh/ruff#5469 #### New Contributors - [@​mayrholu](https://github.com/mayrholu) made their first contribution in [astral-sh/ruff#4903 - [@​hauntsaninja](https://github.com/hauntsaninja) made their first contribution in [astral-sh/ruff#5352 - [@​ethunk](https://github.com/ethunk) made their first contribution in [astral-sh/ruff#5397 - [@​LouisDISPA](https://github.com/LouisDISPA) made their first contribution in [astral-sh/ruff#5475 **Full Changelog**: astral-sh/ruff@v0.0.275...v0.0.276 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/allenporter/flux-local). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNyIsInVwZGF0ZWRJblZlciI6IjM2LjUuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes E731 a "manual" fix in one other context: when the lambda is shadowing another variable in the scope. Function declarations (with shadowing) cause issues for type checkers, and so rewriting an annotation, e.g., in branches of an
ifstatement can lead to failures.Closes #5421.