Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement UnnecessaryListAllocationForFirstElement #5549

Merged
merged 19 commits into from
Jul 10, 2023
Merged

Implement UnnecessaryListAllocationForFirstElement #5549

merged 19 commits into from
Jul 10, 2023

Commits on Jul 9, 2023

  1. Create GetFirstElementOfList rule

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    aebf8a9 View commit details
    Browse the repository at this point in the history

  2. Rename rule to UnnecessaryListAllocationForFirstElement

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    236a23f View commit details
    Browse the repository at this point in the history

  3. Handle slices

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    ab41a98 View commit details
    Browse the repository at this point in the history

  4. Handle non-Name elts in Expr::ListComp

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    29d3519 View commit details
    Browse the repository at this point in the history

  5. Clippy

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    ee56d3f View commit details
    Browse the repository at this point in the history

  6. Implement reviewer comments

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    9a19cac View commit details
    Browse the repository at this point in the history

  7. Add Markdown header to docs

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    1f55441 View commit details
    Browse the repository at this point in the history

  8. Wrap fix in [] if slicing rather than indexing

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    c2db951 View commit details
    Browse the repository at this point in the history

  9. Add test

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    f2fbf2c View commit details
    Browse the repository at this point in the history

  10. Fitler ifs from ListComp expressions

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    f582b48 View commit details
    Browse the repository at this point in the history

  11. Restrict visibility to crate

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    4f4b2c8 View commit details
    Browse the repository at this point in the history

  12. Genericize generator name extraction

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    f1126c8 View commit details
    Browse the repository at this point in the history

  13. Remove scratch file

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    3b1513a View commit details
    Browse the repository at this point in the history

  14. Fix schema

    @evanrittenhouse
    evanrittenhouse committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    4497b80 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Add slice to message

    @evanrittenhouse
    evanrittenhouse committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8a62d93 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 5503_first_list_item

    @charliermarsh
    charliermarsh committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1aaf8c6 View commit details
    Browse the repository at this point in the history

  3. Nits

    @charliermarsh
    charliermarsh committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e0e082e View commit details
    Browse the repository at this point in the history

  4. Tweak docs

    @charliermarsh
    charliermarsh committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a5aed76 View commit details
    Browse the repository at this point in the history

  5. Tweak some logic

    @charliermarsh
    charliermarsh committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0baa605 View commit details
    Browse the repository at this point in the history