Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pass over ellipsis in non-function/class contexts #8049

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

konstin
Copy link
Member

@konstin konstin commented Oct 18, 2023

Split out of #8044: In preview style, ellipsis are also collapsed in non-stub files. This should only affect function/class contexts since for other statements stub are generally not used. I've updated our tests to use pass instead to reflect this, which makes tracking the preview style changes much easier.

This make the formatting changes for preview easier
@konstin
Copy link
Member Author

konstin commented Oct 18, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@konstin konstin merged commit 67b0434 into main Oct 19, 2023
16 checks passed
@konstin konstin deleted the pass-over-ellipsis-for-preview branch October 19, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants